diff --git a/e2e/1_load_ref.sh b/e2e/1_load_ref.sh index 194009545df531a94edc32e0fd987db7c8531b94..b82bc395cd5d2739edb9ad74dfc11de329838916 100644 --- a/e2e/1_load_ref.sh +++ b/e2e/1_load_ref.sh @@ -3,12 +3,14 @@ # CONTANTS REFERENTIELS="criteres etapes hypotheses impactequipements impactreseaux mixelecs typeEquipement correspondanceRefEquipement" +E2E_LOCAL_PATH=../../../e2e + . ./.env . ./utils.sh log "Send referentiel data" for ref in $REFERENTIELS; do log_n - curl -s -XPOST $REFERENTIEL_URL/referentiel/$ref/csv --form file=@input_ref/$ref.csv + curl -s -XPOST $REFERENTIEL_URL/referentiel/$ref/csv --form file=@${E2E_LOCAL_PATH}/input_ref/$ref.csv echo "" done diff --git a/e2e/5_assert.sh b/e2e/5_assert.sh index f61d80ec85b4847a9c4c35eeb7af0ab3485b7244..dd0eef0da2f816bbf7c0bb659a430da37fc405d8 100644 --- a/e2e/5_assert.sh +++ b/e2e/5_assert.sh @@ -3,6 +3,8 @@ ORGANISATION=${1:-org1} NOM_LOT=${2:-lot1} +E2E_LOCAL_PATH=../../../e2e + # load INDICATEUR_URL . ./.env @@ -20,11 +22,11 @@ export_table reseau etapeacv,critere,source,statut_indicateur,trace,version_calc ALL_OK=true for file in $(ls actual/); do echo -n "Check file $file : " - res=$(diff -qs actual/$file expected/$file) + res=$(diff -qs actual/$file ${E2E_LOCAL_PATH}/expected/$file) if [ $? -eq 1 ]; then echo "KO" echo "*** REGRESSION : file $file is different from expected, see file: reports/diff_$file" - diff actual/$file expected/$files > reports/diff_$file + diff actual/$file ${E2E_LOCAL_PATH}/expected/$file > reports/diff_$file ALL_OK=false else echo "OK" diff --git a/services/api-event-calculs/pom.xml b/services/api-event-calculs/pom.xml index 05bf8fa1512398aa19cf76ebc6a1a876b054280e..5021ed004e6ca4acc540f22c89ba710768999dd9 100644 --- a/services/api-event-calculs/pom.xml +++ b/services/api-event-calculs/pom.xml @@ -230,9 +230,6 @@ <serviceInterface>true</serviceInterface> <serviceImplementation>false</serviceImplementation> <booleanGetterPrefix>is</booleanGetterPrefix> - <additionalModelTypeAnnotations> - @lombok.experimental.SuperBuilder - </additionalModelTypeAnnotations> </configOptions> </configuration> </execution> @@ -274,9 +271,6 @@ <serviceInterface>true</serviceInterface> <serviceImplementation>false</serviceImplementation> <booleanGetterPrefix>is</booleanGetterPrefix> - <additionalModelTypeAnnotations> - @lombok.experimental.SuperBuilder - </additionalModelTypeAnnotations> </configOptions> </configuration> </execution> diff --git a/services/api-event-calculs/src/main/java/org/mte/numecoeval/calculs/infrastructure/controller/ExceptionHandler.java b/services/api-event-calculs/src/main/java/org/mte/numecoeval/calculs/infrastructure/controller/ExceptionHandler.java index c9bd236f0749bf3557ae5e533e058d680b86ce9c..f39742a9c5fa0e96cd1d45a493184948be42d114 100644 --- a/services/api-event-calculs/src/main/java/org/mte/numecoeval/calculs/infrastructure/controller/ExceptionHandler.java +++ b/services/api-event-calculs/src/main/java/org/mte/numecoeval/calculs/infrastructure/controller/ExceptionHandler.java @@ -26,11 +26,12 @@ public class ExceptionHandler { * @return l'objet erreur */ private static ErreurRest writeErrorResponse(Exception ex, HttpStatus status) { - return ErreurRest.builder() - .status(status.value()) - .code(status.name()) - .timestamp(LocalDateTime.now()) - .message(ex.getLocalizedMessage()).build(); + var erreurRest = new ErreurRest(); + erreurRest.status(status.value()); + erreurRest.setCode(status.name()); + erreurRest.setTimestamp(LocalDateTime.now()); + erreurRest.setMessage(ex.getLocalizedMessage()); + return erreurRest; } @org.springframework.web.bind.annotation.ExceptionHandler(value = {CalculImpactException.class}) diff --git a/services/api-event-calculs/src/main/java/org/mte/numecoeval/calculs/infrastructure/service/sync/calculs/SyncCalculService.java b/services/api-event-calculs/src/main/java/org/mte/numecoeval/calculs/infrastructure/service/sync/calculs/SyncCalculService.java index b70ac8b57e6541c79364019039743c2cd987e142..7afd35344fd1abee4707a2d308cf521b332fc464 100644 --- a/services/api-event-calculs/src/main/java/org/mte/numecoeval/calculs/infrastructure/service/sync/calculs/SyncCalculService.java +++ b/services/api-event-calculs/src/main/java/org/mte/numecoeval/calculs/infrastructure/service/sync/calculs/SyncCalculService.java @@ -24,7 +24,7 @@ public class SyncCalculService { public ReponseCalculRest calcul(SyncCalculRest syncCalculRest) { - var result = ReponseCalculRest.builder().build(); + var result = new ReponseCalculRest(); if (syncCalculRest.getEquipementPhysiqueIds() != null && !syncCalculRest.getEquipementPhysiqueIds().isEmpty()) { List<CalculSizes> calculSizesList = equipementPhysiqueRepository.findEquipementPhysiqueDTOs(syncCalculRest.getEquipementPhysiqueIds()).stream() diff --git a/services/api-event-calculs/src/test/java/org/mte/numecoeval/calculs/infrastructure/service/sync/calculs/SyncCalculServiceTest.java b/services/api-event-calculs/src/test/java/org/mte/numecoeval/calculs/infrastructure/service/sync/calculs/SyncCalculServiceTest.java index 0d15cf801d133dfa250dc96e7fa7fab1211740af..a32cfcdff34b00a8fa1e39f917a41b16cbacde38 100644 --- a/services/api-event-calculs/src/test/java/org/mte/numecoeval/calculs/infrastructure/service/sync/calculs/SyncCalculServiceTest.java +++ b/services/api-event-calculs/src/test/java/org/mte/numecoeval/calculs/infrastructure/service/sync/calculs/SyncCalculServiceTest.java @@ -56,10 +56,11 @@ class SyncCalculServiceTest { Mockito.when(mainEquipementPhysiqueService.calcul(any())).thenReturn(calculSizes); + var syncCalculRest = new SyncCalculRest(); + syncCalculRest.setEquipementPhysiqueIds(List.of(1L, 2L)); + /* EXECUTE */ - var actual = syncCalculService.calcul(SyncCalculRest.builder() - .equipementPhysiqueIds(List.of(1L, 2L)) - .build()); + var actual = syncCalculService.calcul(syncCalculRest); /* ASSERT */ Assertions.assertEquals(2, actual.getNbrEquipementPhysique()); @@ -81,10 +82,11 @@ class SyncCalculServiceTest { Mockito.when(mainMessagerieService.calcul(any())).thenReturn(calculSizes); + var syncCalculRest = new SyncCalculRest(); + syncCalculRest.setMessagerieIds(List.of(10L, 20L, 30L)); + /* EXECUTE */ - var actual = syncCalculService.calcul(SyncCalculRest.builder() - .messagerieIds(List.of(10L, 20L, 30L)) - .build()); + var actual = syncCalculService.calcul(syncCalculRest); /* ASSERT */ Assertions.assertEquals(3, actual.getNbrMessagerie());